Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dmalloc variant in build_example.py tests target #22171

Merged
merged 4 commits into from
Aug 29, 2022
Merged

Dmalloc variant in build_example.py tests target #22171

merged 4 commits into from
Aug 29, 2022

Conversation

andy31415
Copy link
Contributor

** Reason for 1.0 inclusion **

  • improves developer debuggability and testing
  • does not alter core sdk development (additional build rules only, verified by CI). Only delta is in cross-compile environment which should be a noop in practice.

Problem

Fixes #22170

Want better debuggability, in particular it seems Linux TestRead experiences some dmalloc errors (which I have not yet been able to reproduce outside github CI). See #22160

Change overview

This adds dmalloc and asan targets to build_examples.

Testing

Ran the target locally, saw dmalloc being used (by checking amount of time it takes ... TestRead generally takes 2 seconds without it and 30 seconds with)

@andy31415 andy31415 changed the title Dmalloc on build example tests Dmalloc variant in build_example.py tests target Aug 25, 2022
@github-actions
Copy link

github-actions bot commented Aug 25, 2022 •
edited
Loading

PR #22171: Size comparison from 40d5dab to 543a9b9

Increases (3 builds for cc13x2_26x2, cyw30739)
platform target config section 40d5dab 543a9b9 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672827 672835 8 0.0
.text 583676 583684 8 0.0
lock-mtd LP_CC2652R7 (read/write) 180704 180712 8 0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599442 599450 8 0.0
.app_xip_area 476820 476828 8 0.0
Decreases (6 builds for bl602, cc13x2_26x2, psoc6, telink)
platform target config section 40d5dab 543a9b9 change % change
bl602 lighting-app bl602 .text 1050860 1050856 -4 -0.0
bl602+rpc .text 1082876 1082872 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 178668 178660 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 656687 656679 -8 -0.0
.text 554440 554432 -8 -0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22227605 22227603 -2 -0.0
telink lighting-app tlsr9518adk80d (read/write) 830392 830384 -8 -0.0
text 589150 589148 -2 -0.0
Full report (34 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, mbed, psoc6, telink)
platform target config section 40d5dab 543a9b9 change % change
bl602 lighting-app bl602 (read/write) 1383690 1383690 0 0.0
.bss 120266 120266 0 0.0
.data 4480 4480 0 0.0
.text 1050860 1050856 -4 -0.0
bl602+rpc (read/write) 1429602 1429602 0 0.0
.bss 127706 127706 0 0.0
.data 4600 4600 0 0.0
.text 1082876 1082872 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672827 672835 8 0.0
(read/write) 178668 178660 -8 -0.0
.bss 74388 74388 0 0.0
.data 3372 3372 0 0.0
.rodata 88835 88835 0 0.0
.text 583676 583684 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637555 637555 0 0.0
(read/write) 157948 157948 0 0.0
.bss 73660 73660 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559252 559252 0 0.0
lock-ftd LP_CC2652R7 (read only) 673919 673919 0 0.0
(read/write) 167784 167784 0 0.0
.bss 71484 71484 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596768 596768 0 0.0
lock-mtd LP_CC2652R7 (read only) 656687 656679 -8 -0.0
(read/write) 180704 180712 8 0.0
.bss 67172 67172 0 0.0
.data 3296 3296 0 0.0
.rodata 101767 101767 0 0.0
.text 554440 554432 -8 -0.0
pump-app LP_CC2652R7 (read only) 684551 684551 0 0.0
(read/write) 157960 157960 0 0.0
.bss 71524 71524 0 0.0
.data 3296 3296 0 0.0
.rodata 89927 89927 0 0.0
.text 594140 594140 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669059 669059 0 0.0
(read/write) 173572 173572 0 0.0
.bss 71644 71644 0 0.0
.data 3292 3292 0 0.0
.rodata 85483 85483 0 0.0
.text 583096 583096 0 0.0
shell LP_CC2652R7 (read only) 665526 665526 0 0.0
(read/write) 181488 181488 0 0.0
.bss 76708 76708 0 0.0
.data 3376 3376 0 0.0
.rodata 85782 85782 0 0.0
.text 579428 579428 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586586 586586 0 0.0
.app_xip_area 463244 463244 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592346 592346 0 0.0
.app_xip_area 464220 464220 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599442 599450 8 0.0
.app_xip_area 476820 476828 8 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w0+release (read/write) 646516 646516 0 0.0
.bss 70400 70400 0 0.0
.data 2068 2068 0 0.0
.text 571320 571320 0 0.0
lock k32w0+release (read/write) 704012 704012 0 0.0
.bss 70864 70864 0 0.0
.data 2076 2076 0 0.0
.text 628344 628344 0 0.0
linux all-clusters-app debug (read only) 3037929 3037929 0 0.0
(read/write) 156024 156024 0 0.0
.bss 61920 61920 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85624 85624 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 274635 274635 0 0.0
.text 2584146 2584146 0 0.0
all-clusters-minimal-app debug (read only) 2873793 2873793 0 0.0
(read/write) 147624 147624 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78120 78120 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 274827 274827 0 0.0
.text 2422594 2422594 0 0.0
bridge-app debug+rpc (read only) 2372313 2372313 0 0.0
(read/write) 127584 127584 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67464 67464 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 203464 203464 0 0.0
.text 2006226 2006226 0 0.0
chip-tool debug (read only) 10878417 10878417 0 0.0
(read/write) 657184 657184 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 622168 622168 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 561365 561365 0 0.0
.text 8796500 8796500 0 0.0
chip-tool-ipv6only arm64 (read only) 10264052 10264052 0 0.0
(read/write) 705073 705073 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 649704 649704 0 0.0
.dynamic 560 560 0 0.0
.got 13832 13832 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492132 492132 0 0.0
.text 8119796 8119796 0 0.0
lighting-app debug+rpc (read only) 2597257 2597257 0 0.0
(read/write) 130304 130304 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72488 72488 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 220368 220368 0 0.0
.text 2205986 2205986 0 0.0
lock-app debug (read only) 2580241 2580241 0 0.0
(read/write) 125512 125512 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69512 69512 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 237328 237328 0 0.0
.text 2176258 2176258 0 0.0
ota-provider-app debug (read only) 2357401 2357401 0 0.0
(read/write) 118976 118976 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63336 63336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 209304 209304 0 0.0
.text 1984626 1984626 0 0.0
ota-requestor-app debug (read only) 2522921 2522921 0 0.0
(read/write) 127384 127384 0 0.0
.bss 50368 50368 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68744 68744 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 216128 216128 0 0.0
.text 2134178 2134178 0 0.0
shell debug (read only) 2606233 2606233 0 0.0
(read/write) 142144 142144 0 0.0
.bss 57832 57832 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77224 77224 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 234738 234738 0 0.0
.text 2213074 2213074 0 0.0
thermostat-no-ble arm64 (read only) 2356644 2356644 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140588 140588 0 0.0
.text 1978336 1978336 0 0.0
tv-app debug (read only) 3182745 3182745 0 0.0
(read/write) 257968 257968 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79184 79184 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 259080 259080 0 0.0
.text 2733922 2733922 0 0.0
tv-casting-app debug (read only) 5503505 5503505 0 0.0
(read/write) 160464 160464 0 0.0
.bss 51480 51480 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 100120 100120 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 344273 344273 0 0.0
.text 4887618 4887618 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454312 2454312 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1416956 1416956 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842120 842120 0 0.0
(read/write) 1740372 1740372 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188568 188568 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1217558 1217558 0 0.0
.debug_aranges 111560 111560 0 0.0
.debug_frame 372476 372476 0 0.0
.debug_info 26646621 26646621 0 0.0
.debug_line 3647676 3647676 0 0.0
.debug_loc 3562758 3562758 0 0.0
.debug_ranges 336864 336864 0 0.0
.debug_str 3393925 3393925 0 0.0
.heap 842120 842120 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569449 569449 0 0.0
.symtab 420640 420640 0 0.0
.text 0 0 0 0.0
1540760 1540760 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842856 842856 0 0.0
(read/write) 1683580 1683580 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187832 187832 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1209397 1209397 0 0.0
.debug_aranges 111032 111032 0 0.0
.debug_frame 375556 375556 0 0.0
.debug_info 26383316 26383316 0 0.0
.debug_line 3668080 3668080 0 0.0
.debug_loc 3550395 3550395 0 0.0
.debug_ranges 335480 335480 0 0.0
.debug_str 3382914 3382914 0 0.0
.heap 842856 842856 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533923 533923 0 0.0
.symtab 407232 407232 0 0.0
.text 1484704 1484704 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 851200 851200 0 0.0
(read/write) 1600828 1600828 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179696 179696 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2448 2448 0 0.0
.debug_abbrev 1044070 1044070 0 0.0
.debug_aranges 103200 103200 0 0.0
.debug_frame 345800 345800 0 0.0
.debug_info 21847873 21847873 0 0.0
.debug_line 3239259 3239259 0 0.0
.debug_loc 3249910 3249910 0 0.0
.debug_ranges 301320 301320 0 0.0
.debug_str 3189008 3189008 0 0.0
.heap 851200 851200 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 467204 467204 0 0.0
.symtab 374288 374288 0 0.0
.text 1410296 1410296 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 846168 846168 0 0.0
(read/write) 1638540 1638540 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184712 184712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1051505 1051505 0 0.0
.debug_aranges 103872 103872 0 0.0
.debug_frame 348628 348628 0 0.0
.debug_info 22227605 22227603 -2 -0.0
.debug_line 3248153 3248153 0 0.0
.debug_loc 3289747 3289747 0 0.0
.debug_ranges 304664 304664 0 0.0
.debug_str 3216491 3216491 0 0.0
.heap 846168 846168 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473419 473419 0 0.0
.symtab 377472 377472 0 0.0
.text 1442976 1442976 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808416 808416 0 0.0
bss 71448 71448 0 0.0
noinit 43488 43488 0 0.0
text 571026 571026 0 0.0
lighting-app tlsr9518adk80d (read/write) 830392 830384 -8 -0.0
bss 72304 72304 0 0.0
noinit 43488 43488 0 0.0
text 589150 589148 -2 -0.0

@andy31415 andy31415 merged commit d4bea71 into project-chip:master Aug 29, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@andy31415 @isiu-apple
Dmalloc variant in build_example.py tests target (project-chip#22171)
2484d11 
* Add dmalloc support to build examples test run

* Remove extra target for now - no need for both dmalloc and asan

* Move things a bit to be easier to follow

* Restyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
fast track review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build_examples.py unit test execution does not use dmalloc, however github actions yaml do
2 participants
@andy31415 @woody-apple